Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783454 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-23 12:20:14 EST --- Source file is original. Ok. Summary verified from lib/URI/Title.pm. Ok. License verified from lib/URI/Title.pm. Ok. URL and Source0 are alive. Ok. Description verified from lib/URI/Title.pm. Ok. TODO: Re-format the text to bigger width. Maybe you could remove the three dots. No XS code, noarch BuildArch is Ok. TODO: Build-require `perl(lib)' for tests (t/00bootstrap.t:3). All test pass. Ok. $ rpmlint perl-URI-Title.spec ../SRPMS/perl-URI-Title-1.85-1.fc17.src.rpm ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm drwxr-xr-x 2 root root 0 Jan 23 17:59 /usr/share/doc/perl-URI-Title-1.85 -rw-r--r-- 1 root root 2187 Jul 27 2009 /usr/share/doc/perl-URI-Title-1.85/Changes -rw-r--r-- 1 root root 2711 Jan 23 17:59 /usr/share/man/man3/URI::Title.3pm.gz drwxr-xr-x 2 root root 0 Jan 23 17:59 /usr/share/perl5/vendor_perl/URI drwxr-xr-x 2 root root 0 Jan 23 17:59 /usr/share/perl5/vendor_perl/URI/Title -rw-r--r-- 1 root root 6333 Jun 2 2011 /usr/share/perl5/vendor_perl/URI/Title.pm -rw-r--r-- 1 root root 2653 Feb 11 2011 /usr/share/perl5/vendor_perl/URI/Title/HTML.pm -rw-r--r-- 1 root root 386 Apr 21 2008 /usr/share/perl5/vendor_perl/URI/Title/Image.pm -rw-r--r-- 1 root root 1114 May 6 2004 /usr/share/perl5/vendor_perl/URI/Title/MP3.pm -rw-r--r-- 1 root root 989 May 6 2004 /usr/share/perl5/vendor_perl/URI/Title/PDF.pm -rwxr-xr-x 1 root root 187 Mar 20 2006 /usr/share/perl5/vendor_perl/URI/title.pl File permissions are Ok. TODO: Move /usr/share/perl5/vendor_perl/URI/title.pl to /usr/bin or remove it or package it as documentation. The file is useless here. $ rpm -q --requires -p ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm |sort | uniq -c 1 perl(base) 1 perl(Carp) 1 perl(Encode) 1 perl(Exporter) 1 perl(File::Temp) 1 perl(File::Type) >= 0.22 1 perl(HTML::Entities) 1 perl(HTTP::Request) 1 perl(HTTP::Response) 1 perl(Image::Size) 1 perl(lib) 1 perl(LWP::UserAgent) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(Module::Pluggable) >= 1.2 1 perl(MP3::Info) 1 perl(strict) 1 perl(URI::Title) 1 perl(utf8) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 /usr/bin/perl Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm |sort | uniq -c 1 perl(URI::Title) = 1.85 1 perl-URI-Title = 1.85-1.fc17 1 perl(URI::Title::HTML) 1 perl(URI::Title::Image) 1 perl(URI::Title::MP3) 1 perl(URI::Title::PDF) Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-URI-Title-1.85-1.fc17.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3725932). ??? Otherwise package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review