Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783268 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> 2012-01-21 19:45:09 EST --- Requires: %{name} = %{version}-%{release} should have "isa". You can drop defattr. %{_datadir}/gtk-doc/html/goffice-0.8/ should be marked as documentation, I guess. BUGS and MAINTAINERS could be included as documentation. "gnome" as mentioned is in the description should probably start with a capital letter, being a name. goffice08.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 17) goffice08.src: W: invalid-url Source0: http://ftp.gnome.org/pub/gnome/sources/goffice/0.8.17/goffice-0.8.17.tar.xz HTTP Error 404: Not Found http://ftp.gnome.org/pub/gnome/sources/goffice/0.8/goffice-0.8.17.tar.xz works Rpmlint warns about wrong FSF address, but that is pretty minor, given the whole GPLv2/+ issue. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3720752 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review