Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783414 --- Comment #3 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2012-01-21 06:12:45 EST --- (In reply to comment #2) > Comments: > * licensing: Ok (BSD 2 clauses according upstream website), lacks a LICENSE > file, you should request upstream to include it. Not a blocker (NAB). The file is already included in the sources so the next release will have it. > * rpmlint is not silent: you should request that upstream includes a man page > for rdfpipe (NAB). Will do. > in %install you didn't remove the shebang in all files, i suggest you this > one-liner: > find %{buildroot}%{python_sitelib}/rdfextras -name '*.py' -exec sed -i > '/#!.*python/d' {} \; > => Blocker Done > * since you plan to maintain this package on Fedora and EPEL6, you must remove > any reference to BuildRoot or buildroot cleaning. > => Blocker > > * i strongly suggest that you remove the %defattr macros too. > > * you should use consistently macros (both $RPM_BUILD_ROOT and %{buildroot}), > anyone is fine. > => Blocker Done Updated version: Spec URL: http://pingou.fedorapeople.org/RPMs//python-rdfextras.spec SRPM URL: http://pingou.fedorapeople.org/RPMs//python-rdfextras-0.1-2.el6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review