Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=736577 Lakshmi Narasimhan <lakshminaras2002@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #16 from Lakshmi Narasimhan <lakshminaras2002@xxxxxxxxx> 2012-01-21 01:04:03 EST --- [+]MUST: rpmlint must be run on every package. The output should be posted in the review. rpmlint -i ghc-snap-core-0.7.0.1-1.fc17.src.rpm ghc-snap-core-devel-0.7.0.1-1.fc17.x86_64.rpm ghc-snap-core-0.7.0.1-1.fc17.x86_64.rpm ../ghc-snap-core.spec 3 packages and 1 specfiles checked; 0 errors, 0 warnings. [+]MUST: The package must be named according to the Package Naming Guidelines. [+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec [+]MUST: The package must meet the Packaging Guidelines. Naming-Yes Version-release - Matches No prebuilt external bits - OK Spec legibity - OK Package template - OK, based on cabal2spec-0.25 Arch support - OK Libexecdir - OK rpmlint - yes changelogs - OK Source url tag - OK, validated. Build Requires list - OK Summary and description - OK API documentation - OK [+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [+]MUST: The License field in the package spec file must match the actual license. License is BSD. [+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. LICENSE file is included. [+]MUST: The spec file must be written in American English. [+]MUST: The spec file for the package MUST be legible. [+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task. md5sum snap-core-0.7.0.1.tar.gz c686cbca157485dbef60528aca3f5dff snap-core-0.7.0.1.tar.gz md5sum ghc-snap-core-0.7.0.1-1.fc16.src/snap-core-0.7.0.1.tar.gz c686cbca157485dbef60528aca3f5dff ghc-snap-core-0.7.0.1-1.fc16.src/snap-core-0.7.0.1.tar.gz [+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. Built on x86_64. [+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+]MUST: All build dependencies must be listed in BuildRequires. [+]MUST: Packages must NOT bundle copies of system libraries. [NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. [+]MUST: A package must own all directories that it creates. [+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+]MUST: Permissions on files must be set properly. [+]MUST: Each package must consistently use macros. [+]MUST: The package must contain code, or permissible content. [+]MUST: Large documentation files must go in a -doc subpackage. API documentation in devel package [+]MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release} [NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section [+]MUST: Packages must not own files or directories already owned by other packages. [+]MUST: All filenames in rpm packages must be valid UTF-8. Should items [+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-]SHOULD: Individual source files must mention the license at the beginning of the file. Please request upstream to include the license at the top of each source file. [+]SHOULD: If scriptlets are used, those scriptlets must be sane. cabal2spec-diff is OK. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review