[Bug 783559] Review Request: pcs - Pacemaker Configuration System

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783559

--- Comment #1 from Steven Dake <sdake@xxxxxxxxxx> 2012-01-20 15:38:03 EST ---
1. python_sitelib macro is not necessary in Fedora - please remove it

2. Shouldn't group be in clustering?

3. BuildRoot is not necessary in Fedora - please remove it

4. clean section is not necessary in Fedora - please remove it

5. Why is there a %doc with no content?

6. A copyright isn't valid in the header of a SPEC file and may conflict.  The
license of the spec file is governed by the CLA.

7. %{python_sitelib}/pcs/* is an unowned directory

Once you sort those things out, I'll do a MUST analysis.

Please take care to update the Release field to 2 and the changelog before
posting new spec/rpm.

Regards
-steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]