Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783148 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-20 08:56:33 EST --- > NITPICK: Perl::Critic::Violation is only used in tests; I'd move it below line > 19 and remove the minimum version requirement. Moved. I kept the version as this is prescribed by META.yml. > FIX: Remove English from BRs; it's not an independent package. Done. > TODO: Remove Readonly from Requires; it's automatically picked up by rpmbuild. Of course. > FIX: Final RPM provides different module versions (0.999); I think those should > be corrected to 0.999.002. Well, I don't think this is necessary because they should $VERSION numbers if possible (requires are generated in the same way), I implemented it. Updated package is on the same address. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review