Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=781687 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oget.fedora@xxxxxxxxx |hdegoede@xxxxxxxxxx --- Comment #10 from Hans de Goede <hdegoede@xxxxxxxxxx> 2012-01-20 05:19:44 EST --- Sorry Orcan, but since I've come this far anyway I'm going to steal this review from you. I think there will be plenty of other lv2 packages for you to review instead :) So here is the result of a full review: Good: - rpmlint checks return: lv2-ui.x86_64: E: no-binary lv2-ui.x86_64: W: only-non-binary-in-usr-lib lv2-ui-devel.x86_64: W: no-documentation lv2-ui-devel.x86_64: W: dangling-relative-symlink /usr/include/lv2/lv2plug.in/ns/extensions/ui ../../../../../lib64/lv2/ui.lv2 These can all be ignored. - package meets naming guidelines - package meets packaging guidelines - license (ISC) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Must Fix -------- - owns all directories that it creates As discussed before, you need to Add Requires: lv2core to the main package and Requires: lv2core-devel to the -devel package for proper directory ownership handling Should Fix ---------- - remove "Requires: pkgconfig" from the -devel pkg, having explict Requires on pkgconfig is no longer needed these days (rpm autogenerates them). Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review