Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=782786 --- Comment #5 from Martin Gieseking <martin.gieseking@xxxxxx> 2012-01-18 14:31:54 EST --- Thank you for the immediate review. I've compiled two patches that fix the warnings and reported them upstream: https://bugs.launchpad.net/equalx/+bug/918337 > MUST: The package must be named according to the Package Naming Guidelines. > NEEDSWORK > - The Version should be 0.51 to be in accordance with the package naming > guidelines. > - However, the upstream page clearly states that this is supposed to be 0.5.1. > - Please ask that upstream sanitizes their tarball naming. Done (https://bugs.launchpad.net/equalx/+bug/918340). Let's wait if upstream provides an updated archive. In the meantime I keep this issue unchanged since version string 0.51 would probably introduce problems with future package updates. > - Some source code files specify GPLv3+ license, while some specify the GPL (no > version) and others have no license headers at all. > - The attached LICENSE states that EqualX is distributed under GPLv3+. > The resulting license is thus GPLv3+. However, please ask upstream to add the > missing license boilerplates. Done (https://bugs.launchpad.net/equalx/+bug/918347). > MUST: Optflags are used and time stamps preserved. NEEDSWORK > - Please use the '-p' flag for install. Done. > Furthermore, the summary isn't quite satisfactory. I'd change it to something > like "A graphical editor for writing LaTeX equations". Yes, that's indeed a more descriptive summary. Fixed. > I trust you have sent Source1 upstream? Actually, it's the desktop file from the source archive with a couple of fixes. I'm going to report them upstream, too. I thought it's easier to add a new file than patching the existing one. ;) Spec URL: http://mgieseki.fedorapeople.org/review/equalx.spec SRPM URL: http://mgieseki.fedorapeople.org/review/equalx-0.5.1-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review