Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675234 --- Comment #11 from Mario Santagiuliana <fedora@xxxxxxxxxxxxx> 2012-01-18 06:19:59 EST --- Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint duply-1.5.5.4-1.fc17.noarch.rpm duply.noarch: W: spelling-error %description -l en_US cron -> corn, con, crone duply.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee duply.noarch: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands duply.noarch: W: spelling-error %description -l en_US ftplicity -> duplicity 1 packages and 0 specfiles checked; 0 errors, 4 warnings. rpmlint duply-1.5.5.4-1.fc17.src.rpm duply.src: W: spelling-error %description -l en_US cron -> corn, con, crone duply.src: W: spelling-error %description -l en_US pre -> per, ore, pee duply.src: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands duply.src: W: spelling-error %description -l en_US ftplicity -> duplicity 1 packages and 0 specfiles checked; 0 errors, 4 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/makerpm/675234/duply_1.5.5.4.tgz : MD5SUM this package : d72862e0294c50cd3a98249981d689c1 MD5SUM upstream package : d72862e0294c50cd3a98249981d689c1 [!]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [-]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [!]: MUST Rpmlint output is silent. rpmlint duply-1.5.5.4-1.fc17.noarch.rpm duply.noarch: W: spelling-error %description -l en_US cron -> corn, con, crone duply.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee duply.noarch: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands duply.noarch: W: spelling-error %description -l en_US ftplicity -> duplicity 1 packages and 0 specfiles checked; 0 errors, 4 warnings. rpmlint duply-1.5.5.4-1.fc17.src.rpm duply.src: W: spelling-error %description -l en_US cron -> corn, con, crone duply.src: W: spelling-error %description -l en_US pre -> per, ore, pee duply.src: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands duply.src: W: spelling-error %description -l en_US ftplicity -> duplicity 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Generated by fedora-review 0.1.1 ================================== So for me the package is almost ok. You specify you want include it in EPEL. So the issues are ok. I set this: [!]: MUST Spec file is legible and written in American English. Could you rewrite your spec file "head" to have a line separation in BuildArch and Requires? Could you change the order in Requires and BuildRequires putting BR first the Requires after? I will ask a little opinion to fedora-devel after the little change in spec file I will approve the package. Thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review