Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=782225 --- Comment #5 from David Nalley <david@xxxxxxx> 2012-01-17 13:17:41 EST --- (In reply to comment #3) > From:http://fedoraproject.org/wiki/Java_review_template > > Maven === > [PASS] Use %{_mavenpomdir} macro for placing pom files instead of > %{_datadir}/maven2/poms > [N/A] If package uses "-Dmaven.test.skip=true" explain why it was needed in a > comment > [N/A] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why > it's needed in a comment > [FAIL] Package DOES NOT use %update_maven_depmap in %post/%postun Isn't this in line 43-47 of the existing spec file? > [FAIL] Packages DOES NOT have Requires(post) and Requires(postun) on > jpackage-utils for %update_maven_depmap macro I think line 23 and 24 of the existing spec file take care of this. Thanks for the review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review