[Bug 772284] Review Request: libnl3 - convenience library for kernel netlink API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772284

--- Comment #13 from Thomas Graf <tgraf@xxxxxxxxxx> 2012-01-17 05:23:08 EST ---
(In reply to comment #12)


> libnl3.i686: E: incorrect-fsf-address /usr/share/doc/libnl3-3.2.5/COPYING
> libnl3-cli.i686: E: incorrect-fsf-address
> /usr/share/doc/libnl3-cli-3.2.5/COPYING
>     => upstream should fix this

Will do

> 
> libnl3-devel.i686: W: dangling-relative-symlink
> /usr/lib/libnl/cli/cls/cgroup.so cgroup.so.0.0.0
> libnl3-devel.i686: W: dangling-relative-symlink /usr/lib/libnl/cli/cls/basic.so
> basic.so.0.0.0
> libnl3-devel.i686: W: dangling-relative-symlink /usr/lib/libnl/cli/qdisc/htb.so
> htb.so.0.0.0
> libnl3-devel.i686: W: dangling-relative-symlink
> /usr/lib/libnl/cli/qdisc/bfifo.so bfifo.so.0.0.0
> libnl3-devel.i686: W: dangling-relative-symlink
> /usr/lib/libnl/cli/qdisc/pfifo.so pfifo.so.0.0.0
> libnl3-devel.i686: W: dangling-relative-symlink
> /usr/lib/libnl/cli/qdisc/blackhole.so blackhole.so.0.0.0
>     => doesn't seem as a bug, but are those files libraries or dlopen()-ed
> plugins? Shouldn't they be linked with -avoid-version libtool flag?

Those are dlopen() plugins. They are currently compiled like this:

cli_qdisc_htb_la_LDFLAGS = -module -version-info 0:0:0

I will change it to -avoid-version. Thanks!

> libnl3.i686: W: shared-lib-calls-exit /usr/lib/libnl-route-3.so.199.5.1
> exit@GLIBC_2.0

This I do not understand. git grep exit also does not show anything unusual.

> libnl3-cli.i686: W: shared-lib-calls-exit /usr/lib/libnl-cli-3.so.199.5.1
> exit@GLIBC_2.0
>     => needs a comment

The CLI libraries do issue exit(), f.e. when parsing the argument string
requests printing the help text.

> libnl3-cli.i686: W: manual-page-warning /usr/share/man/man8/nl-qdisc-add.8.gz
> 2: warning: macro `LO' not defined
> libnl3-cli.i686: W: manual-page-warning
> /usr/share/man/man8/nl-classid-lookup.8.gz 2: warning: macro `LO' not defined
> libnl3-cli.i686: W: manual-page-warning
> /usr/share/man/man8/nl-pktloc-lookup.8.gz 2: warning: macro `LO' not defined
>     => upstream issue

Will fix those.

> libnl3-cli.i686: W: no-manual-page-for-binary nl-class-list
> libnl3-cli.i686: W: no-manual-page-for-binary nl-class-delete
> libnl3-cli.i686: W: no-manual-page-for-binary nl-cls-add
> libnl3-cli.i686: W: no-manual-page-for-binary nl-class-add
> libnl3-cli.i686: W: no-manual-page-for-binary nl-cls-list
> libnl3-cli.i686: W: no-manual-page-for-binary nl-link-list
> libnl3-cli.i686: W: no-manual-page-for-binary nl-cls-delete
>     => would be nice to have

Volunteers needed :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]