Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=773021 Scott Tsai <scottt.tw@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #12 from Scott Tsai <scottt.tw@xxxxxxxxx> 2012-01-13 17:20:00 EST --- (In reply to comment #11) Your spec changes look fine. I'll approve this package now and assume FPC ticket 132 will get approved (I'm an optimist ;) > I have discussed that with ajax and airlied yesterday and they seemed generally > positive to bundling. It is just too much work for no benefit (there are no > secuirty issues with piglit). Maybe get them to leave some comments on https://fedorahosted.org/fpc/ticket/132 ? > > Note: Clean is needed only if supporting EPEL > And yes, of course, I want to support EPEL That "Note:" was just boilerplate text generated by the fedora-review tool, please ignore. > > piglit-summary-html shows unstable test results > That's interseting ... which ones? Isn't it a bug in piglit? I uploaded the report to http://scottt.tw/piglit-summary/index.html This is on an Intel Sandy Bridge machine running up to date F16: http://www.smolts.org/client/show_all/pub_19218c58-fdb9-4c7e-81d7-c0d1e5b8c17d Manually scanning over the test results, I see at least these results changing: fbo-3d fbo-sys-blit fbo-sys-blit bgra-sec-color-pointer scissor-clear glsl-deriv-varyings glsl-fs-color-matrix glsl-mat-attribute useprogram-flushverts-1 draw-elements-base-vertex-neg (I only read half way through the result summary page) I do believe these are bugs in piglit or they at least makes the testsuite as a whole hard to use for regression testing. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review