Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=773021 --- Comment #3 from Scott Tsai <scottt.tw@xxxxxxxxx> 2012-01-12 11:00:52 EST --- (In reply to comment #2) > Hmm, fails to build > http://mcepl.fedorapeople.org/tmp/_build-1-0.9.git20120110Rf26fbd0.el6.log Any > ideas what's going on here? I'll give it a shoot but please feel free to beat me to it ^_^ >> the ".py" at the end of "$(basename ${srcfile} .py)" is superfluous. > ... > I am not sure, whether it works with GNU basename, but I don't feel like going > against the standard without a reason. I didn't realize basename has this filename suffix stripping functionality and was totally wrong here. Please ignore. >> tests/util/glew.{ch} is a bundled copy of the "glew" library > .. > Will investigate later ... we have glew on all imagineagble distros so it > shouldn't be the problem, but first let's make the package building again. After looking into the way piglit patches glew: http://cgit.freedesktop.org/piglit/log/tests/util/glew.c http://sourceforge.net/tracker/?func=detail&aid=3433049&group_id=67586&atid=523274 (open glew upstream bug with patch, known piglit crasher) http://sourceforge.net/tracker/?func=detail&aid=3433049&group_id=67586&atid=523274 and http://lists.freedesktop.org/archives/piglit/2012-January/001612.html (MESA on i965 Sandy Bridge can support OpenGL 3.0 but not the ARB_uniform_buffer_object extension, glew upstream apparently never ran into such an OpenGL implementation) Note that piglit is patching glew.c which is in fact an auto generated file in upstream glew. Since piglit tests are often added after a new OpenGL extension / feature is added to some (MESA, hardware driver) combination and the exact OpenGL functionality supported by MESA is necessary "quirky" as it continues to develop I think we can expect the bundled copy of glew in piglit to only occasionally be in sync with upstream. I seriously suggest you use the bundled copy as is or ask FESCO for an bundled library exception if necessary. I've also opened bug 773679 to request that the glew package be updated to 1.7.0 in Fedora. (piglit has patches on top of glew 1.7.0, Fedora currently has glew 1.6.0) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review