Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756635 --- Comment #6 from Jerry James <loganjerry@xxxxxxxxx> 2012-01-11 22:05:35 EST --- (In reply to comment #5) > Sorry for the delay for this review: No problem. I've been quite busy with the mass rebuild for F17 anyway. You've done a lot of work on this review, and I appreciate it a lot. > 1. gap-core should own /usr/lib/gap/ (%{gaparchdir}) since it owns > /usr/lib/gap/sysinfo.gap Done. > 2. For gap-vim, since you're not shipping README.vim-utils I recommend you ship > the attached gap.vim as /usr/share/vimfiles/ftdetect/gap.vim. Otherwise the > user would have to know to manually ":set filetype=vim" to activate the VIM > sytnax hightlighting and indentation plugins. > Hopefully the *.g, *.gi, *.gd file extensions are not used by other file types. Thank you. I've added this. > 3. Placing "README.fedora" in gap-libs and placing "description4r4p10" in > gap-core seems a bit strange to me. Maybe move "README" and "README.fedora" to > gap-core? (not critical) Good point. I have moved the READMEs to gap-core. > 4. Since Fedora packaging lack Debian's "recommand" and "suggest" > functionality, I'm not sure splitting out the prim, small and trans group > subpackages is really a good idea but I'll leave it to your disgression. I think this is still a good idea considering the size of those packages. However, to address the point that we have no way to recommend them, I made the gap metapackage Require all 3 of these. That way, somebody you does "yum install gap" will get them all, and others can be more selective. > 5. I was able to build and load the "Example" package from > http://www.gap-system.org/Packages/packages.html sucessfully. Great! [snip] > I'll approve this as soon as you fix points one and two above. New URLs: http://jjames.fedorapeople.org/gap/gap.spec http://jjames.fedorapeople.org/gap/gap-4.4.12-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review