Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755104 Nuno Santos <nsantos@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Flag| |fedora-review+ --- Comment #3 from Nuno Santos <nsantos@xxxxxxxxxx> 2012-01-10 11:49:35 EST --- I've checked the fixes and have re-reviewed the affected parts: OK - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. md5sums match: $ rpm2cpio condor-wallaby-4.1.2-2.fc15.src.rpm | cpio -ivd ; md5sum condor-wallaby-4.1.2.tar.gz 0001-Packaging-improvements-for-building-on-fedora.patch 0002-Packaging-fixes.patch 0003-Workflow-and-packaging-improvements.patch 0004-Bumped-spec-to-4.1.2-2.patch condor-wallaby-4.1.2.tar.gz condor-wallaby.spec 261 blocks 2bc4dfcf7e6e3368c8a33d43af29406f condor-wallaby-4.1.2.tar.gz $ wget https://fedorahosted.org/releases/g/r/grid/condor-wallaby-4.1.2.tar.gz ; md5sum condor-wallaby-4.1.2.tar.gz --2012-01-10 11:38:51-- https://fedorahosted.org/releases/g/r/grid/condor-wallaby-4.1.2.tar.gz Resolving fedorahosted.org... 66.135.62.191 Connecting to fedorahosted.org|66.135.62.191|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 51416 (50K) [application/x-gzip] Saving to: “condor-wallaby-4.1.2.tar.gz” 100%[==========================================================>] 51,416 199K/s in 0.3s 2012-01-10 11:38:52 (199 KB/s) - “condor-wallaby-4.1.2.tar.gz” saved [51416/51416] 2bc4dfcf7e6e3368c8a33d43af29406f condor-wallaby-4.1.2.tar.gz OK - MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. $ mock -r fedora-rawhide-i386 condor-wallaby-4.1.2-2.fc15.src.rpm INFO: mock.py version 1.1.18 starting... State Changed: init plugins INFO: selinux enabled State Changed: start INFO: Start(condor-wallaby-4.1.2-2.fc15.src.rpm) Config(fedora-rawhide-i386) State Changed: lock buildroot State Changed: clean INFO: chroot (/var/lib/mock/fedora-rawhide-i386) unlocked and deleted State Changed: unlock buildroot State Changed: init State Changed: lock buildroot Mock Version: 1.1.18 INFO: Mock Version: 1.1.18 INFO: calling preinit hooks INFO: enabled root cache INFO: root cache aged out! cache will be rebuilt INFO: enabled yum cache State Changed: cleaning yum metadata INFO: enabled ccache State Changed: running yum State Changed: creating cache State Changed: unlock buildroot INFO: Installed packages: State Changed: setup State Changed: build INFO: Done(condor-wallaby-4.1.2-2.fc15.src.rpm) Config(fedora-rawhide-i386) 4 minutes 16 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-rawhide-i386/result State Changed: end OK - MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. $ rpmlint /var/lib/mock/fedora-rawhide-i386/result/condor-wallaby*.rpm condor-wallaby.src:41: W: unversioned-explicit-obsoletes condor-remote-configuration condor-wallaby.src:61: W: unversioned-explicit-obsoletes condor-remote-configuration-server condor-wallaby-client.noarch: W: non-conffile-in-etc /etc/condor/config.d/99configd.config condor-wallaby-client.noarch: W: no-manual-page-for-binary condor_configd 2 packages and 0 specfiles checked; 0 errors, 4 warnings. (Warnings have been explained in earlier comments) * tarfile issue has been fixed as well: $ tar -xvzf condor-wallaby-4.1.2.tar.gz condor-wallaby-4.1.2/ condor-wallaby-4.1.2/LICENSE-2.0.txt condor-wallaby-4.1.2/Makefile condor-wallaby-4.1.2/README condor-wallaby-4.1.2/condor-wallaby.spec condor-wallaby-4.1.2/condor_configd condor-wallaby-4.1.2/condor_configure_pool condor-wallaby-4.1.2/condor_configure_store condor-wallaby-4.1.2/config/ condor-wallaby-4.1.2/config/99configd.config condor-wallaby-4.1.2/config/pidkill.bat condor-wallaby-4.1.2/doc/ condor-wallaby-4.1.2/doc/condor_configure_pool.1 condor-wallaby-4.1.2/doc/condor_configure_store.1 condor-wallaby-4.1.2/module/ condor-wallaby-4.1.2/module/WallabyHelpers.py condor-wallaby-4.1.2/module/WallabyTypes.py condor-wallaby-4.1.2/module/__init__.py condor-wallaby-4.1.2/module/exceptions.py condor-wallaby-4.1.2/test/ condor-wallaby-4.1.2/test/override.param condor-wallaby-4.1.2/test/override/ condor-wallaby-4.1.2/test/override/.gitignore condor-wallaby-4.1.2/test/store.rb condor-wallaby-4.1.2/test/test_driver.py condor-wallaby-4.1.2/test/test_procedures.txt ========== It all looks good now, package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review