Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753262 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@xxxxxxxxxxxx --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2012-01-09 13:46:32 EST --- OK, here's an initial review : 1. -devel MUST depend on main pkg. add to -devel Requires: %{name}%{?_isa} = %{version}-%{release} 2. SHOULD track ABI, replace %{_libdir}/lib%{name}.so.* with %{_libdir}/libqxmpp-dev.so.2 (or whatever the proper soname is). 3. SHOULD: better to patch/fix lib64 handling properly, instead of current hack: %ifarch x86_64 %__mv ${RPM_BUILD_ROOT}/usr/{lib,lib64} %endif if you can't patch, this is better, %if "%{_lib}" = "lib64" ... %endif (there's more platforms using lib64 than just x86_64) 4. SHOULD use BuildRequires: qt4-devel (instead of qt-devel) 5. MUST fix -devel summary/description to reference qxmpp-dev instead of qxmpp -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review