Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772504 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> 2012-01-09 03:12:12 EST --- I think the package summary does not describe the package very well. The description gave me a completely different view. Defattr is no longer necessary. If you're not going for EPEL 5, you can drop the clean section, buildroot definition and the rm in the install section. Please use the name macro, as you did in Source. Looking at your manpage, you forgot a "d" in %{_localstatedir}/lib/btkbd. There's a macro called sharedstatedir, by the way, that is equivalent to %{_localstatedir}/lib. The FSF address is outdated. Why do you want to own %{_sysconfdir}/udev/rules.d? Why do you require pod2man explicitly? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review