Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737286 --- Comment #15 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2012-01-08 19:23:45 EST --- - %if ! (0%{?rhel} < 7 || 0%{?fedora} < 15) doesn't "work" on f16 as rhel is undefined and 0 is < 7 --> sysV is installed. e.g. this should work: "%if (0%{?rhel} > 7 || 0%{?fedora} > 15)" and below where is "%if (0%{?rhel} < 7 || 0%{?fedora} < 15)" it should be: "%if ! (0%{?rhel} > 7 || 0%{?fedora} > 15)" - http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_spec_file_scriptlets : %preun -n salt-master/minion is missing It seems there are some more errors in the initscripts: salt.src:230: W: macro-in-%changelog %post salt.src:230: W: macro-in-%changelog %postun salt.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/salt/utils/find.py 0644L /usr/bin/env salt-master.noarch: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/salt-master salt-master.noarch: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/salt-master salt-master.noarch: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/salt-master salt-master.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-master salt-master.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-master salt-master.noarch: E: subsys-not-used /etc/rc.d/init.d/salt-master salt-master.noarch: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/salt-syndic salt-master.noarch: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/salt-syndic salt-master.noarch: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/salt-syndic salt-master.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-syndic salt-master.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-syndic salt-master.noarch: W: no-reload-entry /etc/rc.d/init.d/salt-syndic salt-master.noarch: E: subsys-not-used /etc/rc.d/init.d/salt-syndic salt-minion.noarch: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/salt-minion salt-minion.noarch: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/salt-minion salt-minion.noarch: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/salt-minion salt-minion.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-minion salt-minion.noarch: W: service-default-enabled /etc/rc.d/init.d/salt-minion salt-minion.noarch: E: subsys-not-used /etc/rc.d/init.d/salt-minion It seems you have a half copy of a debian initscript or something... You could compare it to http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscript_template and try to clean up rpmlint till it's error/warning free and then correct the macros above to include the systemd scripts. (I didn't need to write one yet, so I won't be of great help here...) (In reply to comment #13) > There is a python26-PyXML, which I've moved properly, but there isn't a yum or > libvirt-python *specifically* for 2.6. I am not sure it affects the > functionality of salt in those areas. I'll bug Thatch and see how he wants to > proceed. Ok, having those deps in "%if (0%{?rhel} > 7 || 0%{?fedora} > 15)" would be best, I think. Then it doesn't clutter in the python26 package, but might lead to a crash (but Thatch will probably fix that ;)) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review