Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737286 --- Comment #13 from Clint Savage <herlo1@xxxxxxxxx> 2012-01-08 15:10:41 EST --- Okay, I think I've cleaned up those things. - You added the systemctrl reloads for non-systemd releases. '%if !' and not plain '%if' needed. Yep, my logic was bad there, fixed it so it should work now. - %{name}.service doens't expand to salt-master.service and salt-minion.service (salt-syndic.service is missing all the way). I just decided to get rid of the macros and use the full names. - Deletion is missing, e.g. see: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd %preun if [ $1 -eq 0 ] ; then # Package removal, not upgrade /bin/systemctl --no-reload disable apache-httpd.service > /dev/null 2>&1 || : /bin/systemctl stop apache-httpd.service > /dev/null 2>&1 || : fi Added! - The service is disabled by default (enabled by default would require an exception: https://fedoraproject.org/wiki/Starting_services_by_default ) But the sysV have it enabled by default... Could you change that to match the same behaviour like in F17? (Same %post etc scripts for them would be great too) I'm not 100% on whether I did this part right, please advise. - I *guess*, the new R "MySQL-python PyXML libvirt-python yum" won't be the same on el5. Could you check that? (assuming you have better access to el5 installs as salt upstream seems to be using that mainly) There is a python26-PyXML, which I've moved properly, but there isn't a yum or libvirt-python *specifically* for 2.6. I am not sure it affects the functionality of salt in those areas. I'll bug Thatch and see how he wants to proceed. - Requires: salt = %{version}-%{release} would be safer than ">=". Fixed. I should have new rpms up shortly. Clint -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review