Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772243 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> 2012-01-08 02:08:38 EST --- Just some comments: - License seems to be GPLv2 or BSD -- not GPLv2+ or BSD - You can use the name macro in Source0 - Comment on the patches in the spec file, if possible - FSF address is wrong in rds-sample.c - Please harmonize the use of RPM_BUILD_ROOT and buildroot macro - If you don't go for EPEL 5, you can delete the buildroot definition, the clean section and the rm in the install section - defattr is no longer necessary - Remove README from the documentation as it holds no valuable information - The optflags are not used when compiling - You can patch the permissions for the executables in rds-tools-make.patch instead of changing them in the install section - What is that rds.conf file about? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review