Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=737286 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #10 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2012-01-07 19:12:55 EST --- (In reply to comment #9) > Okay, systemd support for Fedora15+ has been added to the rpm now. Thanks to > upstream. Hurray, I was just waiting on that :P Review: - name ok - noarch ok - macros everywhere - no libs - no *.la - %files see below (%doc question and more explicit in python_sitelib) - services are not %configed NEEDSWORK: - R: python(abi) is not needed, as it's added automatically anyway (even with version depending on 2.7) - master and minion R the main package, please to that with %{version} - It would be nice to install systemd scripts in rhel 7 (I bet rhel7 will have it ;)) - description of master and minion contain Summary. Please delete that and write e.g. what the packages are needed for (so they have more information than the main package description ;)) - Please be more explicit in python_sitelib, so you know, when the egg fails to build: %{python_sitelib}/salt-%{version}-py?.?.egg-info %{python_sitelib}/salt/ - systemd scripts should be 644 and not 775 - sysV ones should be 755 and not 775 - Shouldn't group be "System Environment/Daemons", System/Utilities is not a standard group. - Missing R MySQL-python in modules/mysql.py PyXML in modules/virt.py libvirt-python in modules/virt.py yum in modules/yumpkg.py - add LICENSE as %doc - ask upstream to add headers - missing BR on systemd-units (and then you can omit defining _unitdir) COMMENTS: - saltstack as URL makes more sense to me than github, but it's a matter of taste... (But at least point to saltstack's github ;)) - why are the man pages marked as %doc? Didn't see that before IIRC. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review