[Bug 771123] Review Request: fex - Field split/extraction like cut/awk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771123

Mattia Verga <mattia.verga@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(mmckinst@nexcess.
                   |                            |net)

--- Comment #2 from Mattia Verga <mattia.verga@xxxxxxxxxx> 2012-01-07 05:34:11 EST ---
- rpmlint checks return:
SPECS/fex.spec: W: invalid-url Source0:
http://semicomplete.googlecode.com/files/fex-1.20100416.2814.tar.gz HTTP Error
404: Not Found
fex.x86_64: W: spelling-error Summary(en_US) awk -> awl, aw, wk
fex.x86_64: W: spelling-error %description -l en_US tokenizeing -> betokening
fex.x86_64: W: no-manual-page-for-binary fex
fex.src: W: spelling-error Summary(en_US) awk -> awl, aw, wk
fex.src: W: spelling-error %description -l en_US tokenizeing -> betokening
fex.src: W: invalid-url Source0:
http://semicomplete.googlecode.com/files/fex-1.20100416.2814.tar.gz HTTP Error
404: Not Found
3 packages and 1 specfiles checked; 0 errors, 7 warnings.

URL is valid (not sure why it says different) and all other warnings can be
ignored except the spelling error in %description.

- naming guidelines and .spec file name: OK
+ packaging guidelines: SEE NOTE 1
- license: OK (BSD), in %doc
- spec file legible, in am. english: OK
- source matches upstream
- package compiles on rawhide (i686/x86_64): OK
- Build Requires: OK
- no locales
- no libraries
- not relocatable
- no directories created
- no duplicate files
- file permissions: OK
+ macros: SEE NOTE 1
- code/content: OK
- no need for -docs
- nothing in %doc affects runtime
- no headers / no need for -devel
- no GUI and no .desktop
- ownership: OK
- filenames: OK

MUST FIX:
--------------
1: The BuildRoot tag is required only for EPEL. 
   If you think to build this package also for EPEL you must add the %clean
section.
   See http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
2: Trivial: fix spelling in %description

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]