[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771851

--- Comment #4 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> 2012-01-06 14:46:16 EST ---
updated version:
SPEC: http://www.matthias-runge.de/fedora/python-ladon.spec
(old version, for reference:
http://www.matthias-runge.de/fedora/python-ladon-1.spec )
SRPM: http://www.matthias-runge.de/fedora/python-ladon-0.6.5-2.fc16.src.rpm


Upstream clarified, license is lgpv3+, updated PKG-INFO on
http://pypi.python.org/pypi/ladon

Bundled library is kept upstream for missing reference for chardet (chardet's
upstream is gone). It should be save to remove ladons bundled lib chardet_py2
and replace the only reference to bundled lib to fedoras version of chardet.

CFLAGS removed, buildroot-removal deleted.


for easier reference:

[mrunge@sofja SPECS]$ diff -u python-ladon-1.spec python-ladon.spec ---
python-ladon-1.spec 2012-01-06 20:31:08.574775992 +0100
+++ python-ladon.spec 2012-01-06 20:44:47.248475349 +0100
@@ -1,18 +1,17 @@
-%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
-
 Name:           python-ladon
 Version:        0.6.5
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Multiprotocol approach to creating a webservice

-License:        GPLv2
+License:        LGPLv3+
 URL:            http://ladonize.org
 Source0:       
http://pypi.python.org/packages/source/l/ladon/ladon-%{version}.tar.gz
 # #md5=07dd1d395d0d7123448d7710bb3da32a

 BuildArch:      noarch
-BuildRequires:  python-devel
+BuildRequires:  python2-devel
 Requires:       python-jinja2
+Requires:       python-chardet

 %description
 Ladon is a framework for exposing methods to several internet service 
@@ -24,22 +23,33 @@
 %prep
 %setup -q -n ladon-%{version}

+# replace reference to bundled lib with fedora's reference
+sed -i 's/chardet_py2/chardet/' src/ladon/ladonizer/collection.py

 %build
-CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build
+%{__python} setup.py build


 %install
-rm -rf $RPM_BUILD_ROOT
 %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
-chmod 755 /%{buildroot}/%{python_sitelib}/ladon/clients/jsonwsp.py
+chmod 755 %{buildroot}/%{python_sitelib}/ladon/clients/jsonwsp.py
+
+# remove file included for windows-builds
+rm %{buildroot}/%{_bindir}/ladon2.7ctl.py
+
+# remove bundled library
+rm -rf %{buildroot}/%{python_sitelib}/chardet_py2

 %files
 %doc PKG-INFO
 %{python_sitelib}/*
 %{_bindir}/ladon2.7ctl
-%{_bindir}/ladon2.7ctl.py

 %changelog
+* Fri Jan 06 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.6.5-2
+- remove unecessary definition, buildroot cleaning
+- remove bundled library chardet_py2, correct reference to use fedora's
version
+- correct build requirements
+
 * Wed Jan 04 2012 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> - 0.6.5-1
 - initial fedora package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]