Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=768545 David Nalley <david@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|VERIFIED |ASSIGNED --- Comment #4 from David Nalley <david@xxxxxxx> 2012-01-06 12:23:13 EST --- (In reply to comment #3) > FAIL SHOULD: If the source package does not include license text(s) as a > separate file from upstream, the packager SHOULD query upstream to include it. > [25] https://github.com/xen-org/blktap/issues/1 Done > FAIL SHOULD: The description and summary sections in the package spec file > should contain translations for supported Non-English languages, if available. > [26] There's no i18n support in this, so NA IMO. - moreover, I can't translate to anything. > FAIL SHOULD: your package should contain man pages for binaries/scripts. If > it doesn't, work with upstream to add them where they make sense.[32] I requested that upstream should create said man pages here: https://github.com/xen-org/blktap/issues/2 In addition I discovered that libtool archives were being built and packaged. I stripped these from the -devel package. New SPEC: http://ke4qqq.fedorapeople.org/blktap.spec New SRPM: http://ke4qqq.fedorapeople.org/blktap-2.0.90-2.git20111216.62de90d.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review