Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771171 --- Comment #3 from Bohuslav Kabrda <bkabrda@xxxxxxxxxx> 2012-01-06 04:41:42 EST --- Thanks for your review! - I corrected the permissions and tabs/spaces. - As for the test error "Error: No module named oauth_provider", this would need django-oauth-plus (see [1]), which is not yet in Fedora (and some of its dependencies aren't there too, if I recall it correctly), so I would leave it this way for the time being. As soon as django-oauth-plus gets into Rawhide (if I manage to get some time, I will package it), I will rebuild with all the tests. Is this a blocker for you? - The upstream source for the tests doesn't in fact exist - you have to download them separately from the Github, as they are not included in the package downloaded from pypy. I believe that running tests is important and this is probably the best way to get them. These are the files with your comments incorporated: SPEC: http://bkabrda.fedorapeople.org/pkgs/django-tastypie/django-tastypie.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/django-tastypie/django-tastypie-0.9.11-2.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624230 [1] https://github.com/toastdriven/django-tastypie/issues/323 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review