[Bug 771837] Review Request: gubbi-fonts - Free Kannada Opentype serif font

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771837

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2012-01-06 03:30:48 EST ---
Review:

+ koji scratch build
->http://koji.fedoraproject.org/koji/taskinfo?taskID=3621137

+ rpmlint on rpms gave
gubbi-fonts.noarch: W: spelling-error %description -l en_US opentype -> open
type, open-type, phenotype
gubbi-fonts.src: W: spelling-error %description -l en_US opentype -> open type,
open-type, phenotype
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ source verified with upstream as (sha1sum)
91dd2e35ab6ac58dd3efcf0ee63109e1901a54bb  gubbi-1.0.tar.gz
91dd2e35ab6ac58dd3efcf0ee63109e1901a54bb  ../SOURCES/gubbi-1.0.tar.gz

+ follows fonts packaging guidelines


Suggestions:
1) you should drop the versioned dependency. Change
BuildRequires: fontforge >= 20080429
to
BuildRequires: fontforge

2)you don't need to clean buildroot now. remove following from spec
BuildRequires: fontforge >= 20080429


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]