Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754754 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-05 08:23:23 EST --- Spec file changes: --- perl-Gtk3.spec.old 2011-12-15 16:09:39.000000000 +0100 +++ perl-Gtk3.spec 2012-01-05 14:02:07.934998296 +0100 @@ -1,7 +1,9 @@ +%global use_x11_tests 1 + Name: perl-Gtk3 Version: 0.002 -Release: 1%{?dist} -Summary: Perl interface to the 3.x series of the gtk+ toolkit +Release: 2%{?dist} +Summary: Perl interface to the 3.x series of the GTK+ toolkit License: LGPLv2+ Group: Development/Libraries URL: http://search.cpan.org/dist/Gtk3/ @@ -12,14 +14,24 @@ BuildRequires: perl(Glib::Object::Introspection) >= 0.002 BuildRequires: perl(Test::More) BuildRequires: gtk3 +BuildRequires: perl(Carp) +BuildRequires: perl(Exporter) +BuildRequires: perl(Test::More) +BuildRequires: perl(Scalar::Util) Requires: perl(Glib) >= 1.240 Requires: perl(Glib::Object::Introspection) >= 0.002 Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) Requires: gtk3 +%if %{use_x11_tests} +# X11 tests: +BuildRequires: xorg-x11-server-Xvfb +BuildRequires: xorg-x11-xinit +BuildRequires: font(:lang=en) +%endif %description -The Gtk3 module allows a Perl developer to use the gtk+ graphical user -interface library. Find out more about gtk+ at http://www.gtk.org. +The Gtk3 module allows a Perl developer to use the GTK+ graphical user +interface library. Find out more about GTK+ at http://www.gtk.org/ %prep %setup -q -n Gtk3-%{version} @@ -37,17 +49,27 @@ %{_fixperms} $RPM_BUILD_ROOT/* %check -# NB, we expect most of these checks to be skipped -# because of lack of a $DISPLAY inside koji -make test +%if %{use_x11_tests} + xinit /bin/sh -c 'rm -f ok; make test && touch ok' -- /usr/bin/Xvfb :666 + test -e ok +%else + make test +%endif %files -%defattr(-,root,root,-) -%doc dist.ini LICENSE NEWS perl-Gtk3.doap README +%doc LICENSE NEWS README %{perl_vendorlib}/* %{_mandir}/man3/* %changelog +* Thu Jan 5 2012 Daniel P. Berrange <berrange@xxxxxxxxxx> - 0.002-2 +- Use xvfb to run test suite +- Fix capitalization of GTK+ +- Remove dist.ini & perl-Gtk3.doap +- Remove defattr from files section +- Add missing BuildRequires for test suite +- Add trailing / into URIs + * Thu Dec 15 2011 Daniel P. Berrange <berrange@xxxxxxxxxx> - 0.002-1 - Update to 0.002 release > TODO: Capitalize the `GTK+' to comply with official name (http://www.gtk.org/). -Summary: Perl interface to the 3.x series of the gtk+ toolkit +Release: 2%{?dist} +Summary: Perl interface to the 3.x series of the GTK+ toolkit -The Gtk3 module allows a Perl developer to use the gtk+ graphical user -interface library. Find out more about gtk+ at http://www.gtk.org. +The Gtk3 module allows a Perl developer to use the GTK+ graphical user +interface library. Find out more about GTK+ at http://www.gtk.org/ Ok. > TODO: Append slash to the URL as conforming HTTP URL must contain path. -The Gtk3 module allows a Perl developer to use the gtk+ graphical user -interface library. Find out more about gtk+ at http://www.gtk.org. +The Gtk3 module allows a Perl developer to use the GTK+ graphical user +interface library. Find out more about GTK+ at http://www.gtk.org/ TODO: You are missing full stop at the and of the description. If you hesitate because of URL, close URL into angle brackets (<http://www.gtk.org/>.). > FIX: Build-require perl(Carp) for tests (lib/Gtk3.pm:8) > TODO: Build-require perl(Exporter) for tests (lib/Gtk3.pm:10) > FIX: Build-require perl(Test::More) for tests (t/00-init.t:6) > FIX: Build-require perl(Scalar::Util) for tests (t/floating-refs.t:7) +BuildRequires: perl(Carp) +BuildRequires: perl(Exporter) +BuildRequires: perl(Test::More) +BuildRequires: perl(Scalar::Util) Ok. > TODO: Run tests against Xvfb to perform X11 tests > (<https://fedoraproject.org/wiki/Perl/Tips#Tests_require_X11_server>; actually > there is easier way using xvfb-run tool). Ok. > TODO: Remove useless %defattr from %files section. > TODO: Do not package dist.ini and perl-Gtk3.doap. They do not provide any useful data not mentioned anywhere else. %files -%defattr(-,root,root,-) -%doc dist.ini LICENSE NEWS perl-Gtk3.doap README +%doc LICENSE NEWS README Ok. All tests pass. Ok. $ rpmlint perl-Gtk3.spec ../SRPMS/perl-Gtk3-0.002-2.fc17.src.rpm ../RPMS/noarch/perl-Gtk3-0.002-2.fc17.noarch.rpm perl-Gtk3.spec:29: W: comparison-operator-in-deptoken font(:lang=en) perl-Gtk3.src:29: W: comparison-operator-in-deptoken font(:lang=en) 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3622033). Ok. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review