[Bug 770152] Review Request: gnome-boxes - A simple GNOME 3 application to access remote or virtual systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770152

--- Comment #9 from Christophe Fergeau <cfergeau@xxxxxxxxxx> 2012-01-05 03:54:59 EST ---
(In reply to comment #8)
> 
> Some comments:
> 
> - in the changelog, you need to escape the macro, so %%{buildroot}
> 

Fixed (locally)

> - did you intend to put something in the %pre section?
> 

Nope, it's some copy and paste from totem, I removed it

> - the address in the COPYING file is wrong - please use the most recent version
> 

I sent a patch upstream to fix this

> - it's not required for the review, but please consider including a manpage

I opened a bug upstream about it:
https://bugzilla.gnome.org/show_bug.cgi?id=667340

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]