Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754754 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-04 12:38:32 EST --- Source tar ball is original. Ok. Summary verified from lib/Gtk3.pm. TODO: Capitalize the `GTK+' to comply with official name (http://www.gtk.org/). License verified from lib/Gtk3.pm and LICENSE. Ok. URL and Source0 are usable. Ok. Package does not contain any architecture depended code. noarch BuildArch is Ok. Description verified from lib/Gtk3.pm. TODO: Capitalize the `GTK+' to comply with official name (http://www.gtk.org/). TODO: Append slash to the URL as conforming HTTP URL must contain path. FIX: Build-require perl(Carp) for tests (lib/Gtk3.pm:8) TODO: Build-require perl(Exporter) for tests (lib/Gtk3.pm:10) FIX: Build-require perl(Test::More) for tests (t/00-init.t:6) FIX: Build-require perl(Scalar::Util) for tests (t/floating-refs.t:7) TODO: Run tests against Xvfb to perform X11 tests (<https://fedoraproject.org/wiki/Perl/Tips#Tests_require_X11_server>; actually there is easier way using xvfb-run tool). TODO: Remove useless %defattr from %files section. TODO: Do not package dist.ini and perl-Gtk3.doap. They do not provide any useful data not mentioned anywhere else. All tests pass. Ok. $ rpmlint perl-Gtk3.spec ../SRPMS/perl-Gtk3-0.002-1.fc17.src.rpm ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm perl-Gtk3.src: W: spelling-error Summary(en_US) gtk -> Gk, gt, GTE perl-Gtk3.src: W: spelling-error %description -l en_US gtk -> Gk, gt, GTE perl-Gtk3.noarch: W: spelling-error Summary(en_US) gtk -> Gk, gt, GTE perl-Gtk3.noarch: W: spelling-error %description -l en_US gtk -> Gk, gt, GTE 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm drwxr-xr-x 2 root root 0 Jan 4 18:27 /usr/share/doc/perl-Gtk3-0.002 -rw-r--r-- 1 root root 24657 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/LICENSE -rw-r--r-- 1 root root 285 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/NEWS -rw-r--r-- 1 root root 289 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/README -rw-r--r-- 1 root root 712 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/dist.ini -rw-r--r-- 1 root root 799 Dec 9 11:37 /usr/share/doc/perl-Gtk3-0.002/perl-Gtk3.doap -rw-r--r-- 1 root root 2632 Jan 4 18:27 /usr/share/man/man3/Gtk3.3pm.gz -rw-r--r-- 1 root root 9665 Dec 9 11:37 /usr/share/perl5/vendor_perl/Gtk3.pm File permissions and layout Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm |sort |uniq -c 1 gtk3 1 perl(Carp) 1 perl(Exporter) 1 perl(Glib) >= 1.240 1 perl(Glib::Object::Introspection) 1 perl(Glib::Object::Introspection) >= 0.002 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires Ok. TODO: Do not export perl(Glib::Object::Introspection) without version. $ rpm -q --provides -p ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm |sort |uniq -c 1 perl(Gtk3) = 0.002 1 perl-Gtk3 = 0.002-1.fc17 Binary provides Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Gtk3-0.002-1.fc17.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3619080). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review