Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771111 David Nalley <david@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |david@xxxxxxx Flag| |fedora-review? --- Comment #14 from David Nalley <david@xxxxxxx> 2012-01-04 09:00:23 EST --- So a couple of additional comments: 1. Please increment the changelog and release every time you make a change. 2. So while I can appreciate that there isn't yet a 'release' and thus you are building from a point in time - I really have some issues with versioning here, and think that calling this 1.0 will create headaches for you down the road. (I am presuming that we don't know if the next release will be 1.0 or 0.1, but regardless there will be version conflicts.) I'd propose you take a look at: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages If it were me, I'd set version to: 0.0 and I'd set release to something like: 2.20120104git9e88d7e%{dist} Also, it's well and fine (if a bit of extra work for the person reviewing your packages) for you to host your own tarball - but you need to add comments to tell us how you got their. One of the things about packages is that it should provide some auditability and repeatability, and while I have faith that you aren't changing source from upstream, I need to be able to create an identical tarball, so provide comments under the source URL that shows me how you generated it so I can generate a replica myself. See: https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review