Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771233 Bohuslav Kabrda <bkabrda@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Bohuslav Kabrda <bkabrda@xxxxxxxxxx> 2012-01-04 01:57:32 EST --- > > - Move %{geminstdir}/README.md to the -doc subpackage, if it is not needed for > > runtime (which I believe it isn't) and mark it with %doc. > > - Also, mark %{gemdir}/doc/%{gemname}-%{version} with %doc. > > Actually I don't think marking -doc subpackage files with %doc is necessary. > Could you point me to a guideline where this is required? I believe that there is no specific guideline for this. But if you take a look at it from the logical point of view, you have two types of files in your -doc subpackage: - The Rakefile and spec/ directory, which are not needed for runtime, so you moved them to -doc subpackage (which is completely ok, I think), but they are not documentation. - The real documentation (README.md and the doc directory). So, to me, it makes sense to distinct these two. Additional comments: - I think it is clearer not to remove the files by "rm", but use %exclude in %files. But this is just my opinion, so not a blocker. - As for the macros vs. commands thing: There are also macros for commands like "rm", so it may be good to use them, once you decide to use macros for some commands. But at this stage, it doesn't have the feeling of inconsistency, so not a blocker. (BTW, I think that using macros for things like "mkdir -p" is not necessary, but again, just my opinion.) - The link in comment #5 points to the first release srpm, so when importing to fedpkg, please make sure to import the second one :) Since none of my additional comments are blockers, this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review