Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770371 --- Comment #7 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> 2012-01-03 18:58:58 EST --- (In reply to comment #6) > Just to be clear here, this package is just the same mess that we said was not > okay before, just in a separate package? Actually I've double checked and the comment from benjamin still stands in few files from the previous review: Quoting Benjamin: https://bugzilla.redhat.com/show_bug.cgi?id=518546#c39 Showing a diff between 1.0.12 and current http://cgit.freedesktop.org/libva/tree/i965_drv_video/shaders/mpeg2/vld/field_backward.g4b?id=libva-1.0.12 http://cgit.freedesktop.org/vaapi/intel-driver/tree/src/shaders/vme/inter_frame.g6b?id=1.0.15 I expected it should be possible to regenerate the code (using the intel-gen4asm) from the ASM files that wasn't always available in the previous versions. Actually, I'm 'only' failing to regenerate shaders/h264/mc/avc_mc.g4b src/shaders/h264/mc/null.g4b and src/shaders/h264/mc/null.g4b.gen5 at least, so I will investigate. That been said, I may have missed another side of the problem raised by ajax: https://bugzilla.redhat.com/show_bug.cgi?id=518546#c38 In this case, it will mean the code may touch codec internals that can be covered. And given that this logic is not implemented in hardware, this will put a perpetual end to any libva intel backend in Fedora. So please close the review if you think it doesn't worth to re-evaluate. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review