Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759057 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #4 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2012-01-03 07:18:01 EST --- The package looks quite good. Just one comment anyway: I think you could get rid of the sed patching, since all the Makefile parameters you modify can be overridden, as below: %build pushd src make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS -c -fPIC" -f ../projects/makefile/alternate\ Makefile.txt popd %install rm -rf $RPM_BUILD_ROOT pushd src make install -f ../projects/makefile/alternate\ Makefile.txt install DESTDIR=$RPM_BUILD_ROOT INSTALL_FILE="install -p" INSTALL_DIR="install -dp" LIBDIR="%{_libdir}" INCLUDEDIR=%{_includedir}/SOIL popd The less you patch, the better it is ^^. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review