Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771111 --- Comment #12 from Steven Dake <sdake@xxxxxxxxxx> 2012-01-01 18:23:15 EST --- PYTHON specific review guidelines: MUST To build a package containing python2 files, you need to have BuildRequires: python2-devel FAIL: Please remove the odd BuildRequires setup.py should be executable in the tarball Please remove the python_sitelib macros. These are not needed in Fedora. Must: Python eggs must be built from source. They cannot simply drop an egg from upstream into the proper directory. (See prebuilt binaries Guidelines for details) PASS Must: Python eggs must not download any dependencies during the build process. PASS Must: When building a compat package, it must install using easy_install -m so it won't conflict with the main package. N/A Must: When building multiple versions (for a compat package) one of the packages must contain a default version that is usable via "import MODULE" with no prior setup. Should: A package which is used by another package via an egg interface should provide egg info. N/A -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review