Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771111 --- Comment #10 from Steven Dake <sdake@xxxxxxxxxx> 2012-01-01 17:55:25 EST --- Initial take on spec file: 1. Release should be: Release: 1%{?dist} This will trigger .fc16 or .fc17 to be placed in the rpm spec file. 2. BuildRoot is no longer needed in Fedora. Please remove these lines. 3. BuildArch is not needed in Fedora. Please remove these lines. 4. %clean section is no longer needed in Fedora. Please remove this section. 5. %{python_sitelib}/ovirtsdk is an unowned dir. To own it, change the line to: %dir %attr(0755, root, root) %{python_sitelib}/ovirtsdk 6. The %description section should contain more details and proper sentences rather then a Summary (this is what %summary is for). For example : This package contains The oVirt Software Development Kit. With this package, custom software can be built for ovirt (or whatever it does..). 7. The %install section should not contain anything that removes the buildroot. Remove: [ "%{buildroot}" != "/" ] && rm -rf %{buildroot} 8. The #Source0 should be removed. checked in spec files should not have "commented out code". 9. What is oschreib@xxxxxxxxxxxxxx? Please correct the changelog. 10. If I was a sponsor, I would not approve a package for a snapshot of a source repository that was not released as an official upstream artifact. MUST review next. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review