Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771070 --- Comment #5 from Michal Ambroz <rebus@xxxxxxxxx> 2012-01-01 15:44:39 EST --- SPEC URL: http://rebus.fedorapeople.org/SPECS/nwipe.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/nwipe-0.05-3.fc16.src.rpm (In reply to comment #3) > Also in your case you must use %clean stage. Added - thanks for spotting. (In reply to comment #4) > Why did you apply fsf.patch? > I think it has no any sense for users and can be dropped. > You should apply only those patches which have some effects for Fedora > users. According to several discussions with Tom Spot Callaway on the list it seems that this thing is important, should be reported upstream and sooner or later fixed. I know having the patch is not required, but packagers are welcomed and permitted to do so. See his email in the legal list: http://lists.fedoraproject.org/pipermail/legal/2011-August/001701.html Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review