[Bug 770986] Review Request: rubygem-kgio - Kinder, gentler I/O for Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=770986

--- Comment #4 from Guillermo Gómez <guillermo.gomez@xxxxxxxxx> 2012-01-01 13:28:45 EST ---
(In reply to comment #3)
> For -2:
> * Build failure
>   - -2 won't build - %check fails because ruby could not find
>     kgio_ext.so

Fixed

> * Patches
>   - %check is not build phase and if you want to apply patches
>     *on the files to be packaged*,....

Fixed (moved to %install section)

> * Unused macro
>   - %ruby_sitelib macro is defined in the spec file but is
>     used nowhere.

Fixed (removed)

new SPEC url:http://gomix.fedorapeople.org/rubygem-kgio/rubygem-kgio.spec
new SRPM
url:http://gomix.fedorapeople.org/rubygem-kgio/rubygem-kgio-2.7.0-3.fc16.src.rpm

$ rpmlint -v SPECS/rubygem-kgio.spec 
SPECS/rubygem-kgio.spec: I: checking-url
http://rubygems.org/downloads/kgio-2.7.0.gem (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -v SRPMS/rubygem-kgio-2.7.0-3.fc16.src.rpm 
rubygem-kgio.src: I: checking
rubygem-kgio.src: I: checking-url http://bogomips.org/kgio (timeout 10 seconds)
rubygem-kgio.src: I: checking-url http://rubygems.org/downloads/kgio-2.7.0.gem
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -v RPMS/x86_64/rubygem-kgio-2.7.0-3.fc16.x86_64.rpm 
rubygem-kgio.x86_64: I: checking
rubygem-kgio.x86_64: I: checking-url http://bogomips.org/kgio (timeout 10
seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -v RPMS/x86_64/rubygem-kgio-doc-2.7.0-3.fc16.x86_64.rpm 
rubygem-kgio-doc.x86_64: I: checking
rubygem-kgio-doc.x86_64: I: checking-url http://bogomips.org/kgio (timeout 10
seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

:) Thanks again for reviewing

_- Guillermo -_

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]