Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771111 --- Comment #2 from Ofer Schreiber <oschreib@xxxxxxxxxx> 2012-01-01 10:23:25 EST --- (In reply to comment #1) > Here's some comments (I'm not a packager): > > - Changelog entry does not have version-release number > ref: http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs Fixed. > > - You can use %{version} %{release} macros in Source0 url\ Fixed. > > - If you're not going to support epel5, you can remove %defattr and BuildRoot > definition I don't know about that yet > > - Source in SRPM and URL does not match (sha1): > > 67a2941be6370a011bdb8535108b2b75181f4a3e ovirt-engine-sdk-1.0-1.tar.gz > 558f6bde9b2904fc30018f1b0f9e8914b007710e ovirt-engine-sdk-1.0-1.tar.gz Fixed. Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review