Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770986 --- Comment #2 from Guillermo Gómez <guillermo.gomez@xxxxxxxxx> 2011-12-31 14:52:21 EST --- (In reply to comment #1) > * Build failure > - Build fails on F-17: > http://koji.fedoraproject.org/koji/taskinfo?taskID=3611721 * For now rdoc-generated files arch-dependent * It builds fine now in rawhide > * Arch dependent binary module > - kgio_ext.so is arch-dependent and must be placed under > %ruby_sitearch . Please check ruby packaging guideline. Oops, fixed > * Redundant items > - The following items are now redundant on Fedora (may not > be under EPEL) > - BuildRoot: line > - %clean section (completely) > - %defattr at the beginning of %files I reviewed the items against epel guidelines because i plan to include epel version releases. - BuildRoot line will keep if not a blocker (MUST in EPEL) - %clean section (MUST in EPEL) - %defattr at the beginning of %files, (removed) > * rpmlint issue > - Please suppress (fix) the following rpmlint issues > ------------------------------------------------------------ > rubygem-kgio-doc.noarch: E: non-readable > /usr/lib/ruby/gems/1.8/gems/kgio-2.7.0/NEWS 0600L > rubygem-kgio-doc.noarch: E: non-readable > /usr/lib/ruby/gems/1.8/gems/kgio-2.7.0/ChangeLog 0600L > ------------------------------------------------------------ Hmmm, this issues disappeared after removing noarch for doc subpackage. fixed > * Documentation files placement > - README file should be in main package, not -doc, because > it says "README". > - NEWS, ChangeLog can be in main package (and I recommend > so), however not a blocker. * README, NEWS, ChangeLog location fixed > * Enabling test suite > - As this gem contains test/ directory, please add %check > section and execute some tests there > Note: you may see some errors for missing "strace" module > on ./test/test_autopush.rb:3, however I think this can be > patched out. yes.. did it.. dont know if the best way...included patch0 just for test_autopush.rb. %check section added > By the way, I appreciate it if you would review my review request > (bug 770796) I'll take a look asap $ rpmlint -v SRPMS/rubygem-kgio-2.7.0-2.fc16.src.rpm rubygem-kgio.src: I: checking rubygem-kgio.src: I: checking-url http://bogomips.org/kgio (timeout 10 seconds) rubygem-kgio.src: I: checking-url http://rubygems.org/downloads/kgio-2.7.0.gem (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v RPMS/x86_64/rubygem-kgio-2.7.0-2.fc16.x86_64.rpm rubygem-kgio.x86_64: I: checking rubygem-kgio.x86_64: I: checking-url http://bogomips.org/kgio (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v RPMS/x86_64/rubygem-kgio-doc-2.7.0-2.fc16.x86_64.rpm rubygem-kgio-doc.x86_64: I: checking rubygem-kgio-doc.x86_64: I: checking-url http://bogomips.org/kgio (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Not sure about my method for patching the test file (not really good at patching so far). New spec:http://gomix.fedorapeople.org/rubygem-kgio/rubygem-kgio.spec New srpm:http://gomix.fedorapeople.org/rubygem-kgio/rubygem-kgio-2.7.0-2.fc16.src.rpm thanks ! _- Guillermo -_ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review