Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: roundcubemail - Round Cube Webmail is a browser-based multilingual IMAP client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225575 lxtnow@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |roundcubemail - Round Cube |roundcubemail - Round Cube |Webmail is a browser-based |Webmail is a browser-based |multilingual IMAP client |multilingual IMAP client ------- Additional Comments From lxtnow@xxxxxxxxx 2007-01-31 09:58 EST ------- ---Spec file review --- * your %define is not especially necessary * Buildroot doesn't right, it misses one "-" just after "root" (must be fix). * Use 'mkdir -p' instead of 'install -d' as below in you field %install * Use 'install -m 644 *' instead of 'cp -pr *' for install all files in %{_datadir}/roundcubemail with 644 permission, like that, you will not have to atribute permissions to each files and sub-directories in %files. * You should comment why you modify or remove file from main tarball in spec file for more understanding and best review. * Doc INSTALL should not be includes in the package (must be fix) * Many of files listed twice in %files section (must be fix). * %attr(0644-root,root) can be set in %intall section. * You shoul define the default maccros in %files. --- rpmlint error --- * from srpm: clean * from rpm: E: roundcubemail non-standard-gid /usr/share/roundcubemail/temp apache E: roundcubemail non-standard-dir-perm /usr/share/roundcubemail/temp 0775 E: roundcubemail non-standard-gid /usr/share/roundcubemail/logs apache E: roundcubemail non-standard-dir-perm /usr/share/roundcubemail/logs 0775 All must be Fix. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review