Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770174 --- Comment #4 from Hans de Goede <hdegoede@xxxxxxxxxx> 2011-12-29 10:27:03 EST --- (In reply to comment #3) > Thank you Hans, I think I've corrected the issues you pointed out. Thanks, I see you addressed all the mentioned issues, still I would like to see one more revision, to address 2 small things with how you fixed things: 1) It is usual for %post[un|trans] scripts to be added to the spec file before %files, so please move all three to above %files 2) The way you fixed the executable .desktop file is a bit non standard, it works, but the usual way to fix things like this would be to add: chmod -x %{buildroot}%{_kde4_datadir}/applications/kde4/%{name}.desktop To %install (after the make install) > I saw that in /usr/share/applications/kde4 there are many .desktop files with > permission set to 755, so I thought it was a false positive from rpmlint... at > least for KDE apps No rpmlint is right to warn, it is not like you can do: /usr/share/applications/kde4/kde-partitionmanager.desktop And have it do something, like you can do ie: /bin/ls And have it do something, so the file should not be marked executable. If more kde4 packages are doing this then I say BAD kde4 ! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review