[Bug 728302] Review Request: pjproject - Libraries written in C language for building embedded/non-embedded VoIP applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728302

--- Comment #11 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2011-12-27 13:56:57 EST ---
A few initial comments, 

As there's only a static library, 

1.  MUST drop ldconfig scriptlet(s).

2.  there's no need that I can tell for any main runtime package here.
MUST move %{_libdir}/lib*.a to -devel subpkg

3.  MUST add Provides: %{name}-static = %{version}-%{release} to -devel

4.  SHOULD drop --libdir=%{_libdir} , %%configure macro already includes that
by default

Oh my,
/usr/lib64/libpjsip-simple-x86_64-unknown-linux-gnu.a
wtf are they embedding the platform into the library name.  I suppose if that's
how this library is expected to work, so be it, but that's ... unconventional.

5.  MUST fix libpjproject.pc on my x86_64 install, 1.10-4 still contains
libdir=${exec_prefix}/lib

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]