Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770174 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hdegoede@xxxxxxxxxx Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx --- Comment #2 from Hans de Goede <hdegoede@xxxxxxxxxx> 2011-12-27 09:00:12 EST --- Hi, I'll review this and when the review is done I'll sponsor you, removing needsponsor blocker. Good: - rpmlint checks return: kde-partitionmanager.src: W: spelling-error %description -l en_US resize -> reside, re size, re-size kde-partitionmanager.src: W: spelling-error %description -l en_US reiserfs -> Dreiser, serfs kde-partitionmanager.src: W: spelling-error %description -l en_US jfs -> ifs, jiffs kde-partitionmanager.src: W: spelling-error %description -l en_US xfs -> xis, ifs, xrefs kde-partitionmanager.src: W: invalid-url Source0: kde-partitionmanager-1.0.3-20111223svn.tar.gz kde-partitionmanager.x86_64: W: spelling-error %description -l en_US resize -> reside, re size, re-size kde-partitionmanager.x86_64: W: spelling-error %description -l en_US reiserfs -> Dreiser, serfs kde-partitionmanager.x86_64: W: spelling-error %description -l en_US jfs -> ifs, jiffs kde-partitionmanager.x86_64: W: spelling-error %description -l en_US xfs -> xis, ifs, xrefs kde-partitionmanager.x86_64: E: invalid-soname /usr/lib64/libpartitionmanagerprivate.so libpartitionmanagerprivate.so kde-partitionmanager.x86_64: E: invalid-soname /usr/lib64/libpartitionmanagerfatlabel.so libpartitionmanagerfatlabel.so kde-partitionmanager.x86_64: E: script-without-shebang /usr/share/applications/kde4/kde-partitionmanager.desktop kde-partitionmanager.x86_64: W: no-manual-page-for-binary partitionmanager kde-partitionmanager.x86_64: W: no-manual-page-for-binary partitionmanager-bin 3 packages and 0 specfiles checked; 3 errors, 11 warnings. These can all be ignored except for the script-without-shebang warning, see MUST FIX section - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - no duplicate files - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file properly validated. MUST FIX: -------------- - Icons are installed under the freedesktop icon standard icon dir, so you need to add icon cache update scriplets, see: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - The .desktop file: /usr/share/applications/kde4/kde-partitionmanager.desktop is installed as being an executable file (chmod 755), it should be 644 instead. - You must add a "Requires: kde-filesystem-4" for ownership of dirs like /usr/share/kde4/apps ans /usr/share/applications/kde4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review