Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=699316 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pikachu.2014@xxxxxxxxx --- Comment #5 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2011-12-24 18:04:20 EST --- Some comments: - About the Requires: don't rely on "texlive-latex", but rather on "tex(latex)", as explained here: http://fedoraproject.org/wiki/Packaging_tricks#Installing_TeX_files_.28unvetted.29 If one day Fedora decides to switch to another (La)TeX distribution (it already happened once, from teTeX to TeXLive), there will be no need to fix the Requires on TeX tools, thanks to this virtual Provides. - There's an extra underscore after "Inkscape" in the description. - You can remove the BuildRoot tag, as well as all build root cleaning stuff. You can also remove the %defattr macro in %files: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions - There is a stable version 0.4.4, but you packaged a developement version one. Could you justify your choice? - You can remove python-lxml from the Requires, it is already required by inkscape. - About this line: %attr(644,root,root) %{_datadir}/inkscape/extensions/textext.inx If you need to fix the rights of some installed file, you'd better using the install in %install: you can use the following line instead of "cp": install -pm 0644 textext.py %{buildroot}%{_datadir}/inkscape/extensions/ - Don't forget to set the Group tag for this package. You can use the same than inkscape, that is to say: Group: Applications/Productivity -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review