[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=756772

--- Comment #6 from Adam Huffman <bloch@xxxxxxxxxxxx> 2011-12-23 12:02:28 EST ---
1. Could you explain the extra_release tag, that doesn't seem to be referred to
elsewhere in the spec?

2.  Most of the rpmlint errors are just spelling and can be ignored.  However,
it would be nice to have manpages or other documentation - not that this is a
reason to hold up the package.

3.  I'm assuming it depends upon too many new things to be suitable for EPEL5,
so those warnings can be ignored.

4.  Could those %define statements be %global instead?  I've been led to
believe %global is preferred now: 
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]