[Bug 769832] Review Request: kmod - Linux kernel module management utilities (official replacement for module-init-tools)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769832

--- Comment #3 from Neil Horman <nhorman@xxxxxxxxxx> 2011-12-22 08:39:27 EST ---
rpmlint output on source package:
[nhorman@hmsreliant jcm]$ rpmlint ./kmod-2-2.fc17.src.rpm 
kmod.src: W: spelling-error %description -l en_US filesystems -> file systems,
file-systems, systematizes
kmod.src:20: W: unversioned-explicit-obsoletes modutils-devel
kmod.src:20: W: unversioned-explicit-obsoletes modutils
kmod.src:78: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib
kmod.src:79: E: hardcoded-library-path in $RPM_BUILD_ROOT/lib/modprobe.d
kmod.src:106: E: hardcoded-library-path in /lib/modprobe.d
kmod.src: W: invalid-url Source0: kmod-2.tar.xz
1 packages and 0 specfiles checked; 3 errors, 4 warnings.

I'd ignore the filesystem warning, I think the spell checker  is overly
sensitive there anyway.

The unversioned Obsoletes is certainly a problem, as It would seem to prevent
the side-by-side installation. I'd suggest removing it given that you plan to
do a kmod-prefix on your tools to make it parallel install.  You can add it
back later.

I expect you want to replace the lib in the mkdirs on line 78/79/106 with
%{_libdir}

The url you want on line 106 I think is
http://packages.profusion.mobi/kmod/%{name}-%{version}.tar.xz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]