Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752089 --- Comment #3 from Darryl L. Pierce <dpierce@xxxxxxxxxx> 2011-12-21 11:24:03 EST --- (In reply to comment #2) > License > - The "main" license should be MIT as COPYING says so. > setup.rb is written by Minero Aoki and it seems > this script is used not only by this software > (by searching with google), so this script is not directly > this software's product. > > So for now I think the license tag should be "MIT" or > "MIT and LGPLv2" (not LGPLv2+, setup.rb is version 2.1 > specific). Fixed. > * Documents > - The following files should be moved to -doc > --------------------------------------------------- > %{geminstdir}/Rakefile > %{geminstdir}/setup.rb > %{geminstdir}/wirble.gemspec Done. > --------------------------------------------------- > - The following files can be marked as %doc. > --------------------------------------------------- > %{geminstdir}/_irbrc Done. > --------------------------------------------------- > > * Macros > - %ruby_sitelib is just defined but not used anywhere. Removed. > Other things seems okay. Updated Spec: http://mcpierce.fedorapeople.org/rpms/rubygem-wirble.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-wirble-0.1.3-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review