Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=678674 Darryl L. Pierce <dpierce@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Darryl L. Pierce <dpierce@xxxxxxxxxx> 2011-12-21 11:13:24 EST --- All looks good, with the following notes: * MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] OUTPUT: mcpierce@mcpierce-laptop:review $ rpmlint rubygem-goocanvas-1.0.3-1.fc.src.rpm rubygem-goocanvas.src: E: changelog-time-in-future 2011-12-22 rubygem-goocanvas.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: line 1) 1 packages and 0 specfiles checked; 1 errors, 1 warnings. The changelog in the future may just be a timezone issue. * The package must have a Requires and a BuildRequires on rubygems I see no such elements in the specfile. All else looks good. With the Requires/BuildRequires changes made, I approve this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review