Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 --- Comment #4 from Tom Hughes <tom@xxxxxxxxxx> 2011-12-21 10:52:19 EST --- Mostly looks good, just a couple more comments: MUST Package requires other packages for directories it uses. MUST Package must own all directories that it creates. need GConf2 for %{_datadir}/GConf/gsettings need hicolor-icon-theme for %{_datadir}/icons/hicolor need shared-mime-info for %{_datadir}/mime/packages need dbus for %{_datadir}/dbus-1/services need gtk-doc for %{_datadir}/gtk-doc/html Some of those may already be required indirectly, but I haven't found a goot way to work our the full list of indirect requirements. MUST Rpath absent or only used for internal libs. MUST Rpmlint output is silent. gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libgcr-3.so.1.0.0 ['/usr/lib64'] gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/gcr-viewer ['/usr/lib64'] gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libgcr-base-3.so.1.0.0 ['/usr/lib64'] gcr.x86_64: E: binary-or-shlib-defines-rpath /usr/libexec/gcr-prompter ['/usr/lib64'] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review