Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=765652 --- Comment #9 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2011-12-21 10:09:59 EST --- About the patches: # Fix empty debuginfo package : Patch0: %{name}-%{version}-no_strip.patch # Move from /usr/lib64/bmore.help to /usr/share/bvi/bmore.help : Patch1: %{name}-%{version}-fix_help_install.patch You shoudn't use the version macro in patches, otherwise you'll have to rename them each time bvi is updated. Just set the version explicetely, it's also a way to keep an history of the included patches: # Fix empty debuginfo package : Patch0: %{name}-1.3.2-no_strip.patch # Move from /usr/lib64/bmore.help to /usr/share/bvi/bmore.help : Patch1: %{name}-1.3.2-fix_help_install.patch Instead of using sed to fix the help file path in the man page, you'd better merge this fix in the bvi-1.4.2-fix_help_install.patch file. By the way, just for information, you can use a different separator (| or @, for example) in sed, instead of escaping slashes: sed -i "s|/usr/local/share/bmore.help|/usr/share/bvi/bmore.help|" bmore.1 sed -i "s@/usr/local/share/bmore.help@/usr/share/bvi/bmore.help@" bmore.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review